Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to end test workflow #30

Merged
merged 77 commits into from
Sep 16, 2024
Merged

End to end test workflow #30

merged 77 commits into from
Sep 16, 2024

Conversation

Brainicism
Copy link
Owner

@Brainicism Brainicism commented Sep 15, 2024

@grqz

This comment was marked as resolved.

@Brainicism Brainicism changed the title E2e test End to end test workflow Sep 15, 2024
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
- show `waiting for the server to be up` only once
- reduce timeout
- sleep less per loop
wrong: this commit contains intentional issues or reserved a bug from previous commits intentionally in order to test the ci
wrong: this commit contains intentional issues or reserved a bug from previous commits intentionally in order to test the ci
wrong: this commit contains intentional issues or reserved a bug from previous commits intentionally in order to test the ci
wrong: this commit contains intentional issues or reserved a bug from previous commits intentionally in order to test the ci
wrong: this commit contains intentional issues or reserved a bug from previous commits intentionally in order to test the ci
wrong: this commit contains intentional issues or reserved a bug from previous commits intentionally in order to test the ci
wrong: this commit contains intentional issues or reserved a bug from previous commits intentionally in order to test the ci
wrong: this commit contains intentional issues or reserved a bug from previous commits intentionally in order to test the ci
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@grqz
Copy link
Collaborator

grqz commented Sep 15, 2024

@Brainicism
Copy link
Owner Author

@grqz
Copy link
Collaborator

grqz commented Sep 16, 2024

i see. it seems to be because we're giving the response of function ping to jq. we should still keep the echo command out. probably before the timeout. but not sure why it succeeded on the latest commit. maybe the server was starting up too fast that the body is not run at all(?)

Copy link
Collaborator

@grqz grqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brainicism Brainicism merged commit be847ed into master Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants